Skip to content

tools: update to ESLint 5.11.1 and enable no-useless-catch rule #25236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2018
Merged

tools: update to ESLint 5.11.1 and enable no-useless-catch rule #25236

merged 2 commits into from
Dec 29, 2018

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 27, 2018

no-useless-catch was introduced in ESLint 5.11.0. I tried to enable the rule then, but it had a bug. The bug is fixed in 5.11.1, which is the entirety of the ESLint update. This PR enables no-useless-catch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2075/pipeline

@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. vm Issues and PRs related to the vm subsystem. labels Dec 27, 2018
@cjihrig
tools: update ESLint to 5.11.1
1d3a414 
Update ESLint to 5.11.1.

PR-URL: nodejs#25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig
tools: enable no-useless-catch lint rule
baf0396 
This commit enables ESLint's no-useless-catch rule.

PR-URL: nodejs#25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig merged commit baf0396 into nodejs:master Dec 29, 2018
@cjihrig cjihrig deleted the eslint branch December 29, 2018 18:39
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
tools: update ESLint to 5.11.1
f944a75 
Update ESLint to 5.11.1.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
tools: enable no-useless-catch lint rule
e6b5232 
This commit enables ESLint's no-useless-catch rule.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
tools: update ESLint to 5.11.1
81291e7 
Update ESLint to 5.11.1.

PR-URL: nodejs#25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
tools: enable no-useless-catch lint rule
4db40e6 
This commit enables ESLint's no-useless-catch rule.

PR-URL: nodejs#25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
tools: update ESLint to 5.11.1
d167372 
Update ESLint to 5.11.1.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig @BethGriggs
tools: enable no-useless-catch lint rule
19b36d9 
This commit enables ESLint's no-useless-catch rule.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
tools: update ESLint to 5.11.1
08c1cf1 
Update ESLint to 5.11.1.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig @BethGriggs
tools: enable no-useless-catch lint rule
ff67c1e 
This commit enables ESLint's no-useless-catch rule.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig @BethGriggs
tools: update ESLint to 5.11.1
2d1aaf0 
Update ESLint to 5.11.1.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@cjihrig @BethGriggs
tools: enable no-useless-catch lint rule
4427e5a 
This commit enables ESLint's no-useless-catch rule.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
tools: update ESLint to 5.11.1
0098cde 
Update ESLint to 5.11.1.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
tools: enable no-useless-catch lint rule
b7095ba 
This commit enables ESLint's no-useless-catch rule.

PR-URL: #25236
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig @nodejs-github-bot @jasnell @lpinca @BridgeAR